Skip to content

Conversation

@pngwn
Copy link
Member

@pngwn pngwn commented Dec 3, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @d3sandoval we'll need to be careful to put the title in quotes going forward to make it valid frontmatter (we're working on migrating the site to https://github.com/sveltejs/sites - the blog posts will still live here, but converting the markdown will be done differently after migration)

@benmccann benmccann merged commit 791e40d into master Dec 3, 2021
@benmccann benmccann deleted the blog-yaml-fix branch December 3, 2021 14:55
@DreaminDani
Copy link
Contributor

Sounds great! Will add it to my template :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants