-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[docs] Rename a variable count_value to countValue in the Stores section
#7180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
changing from i'm ambivalent on the variable name. either one seems fine to me I think changing the text from "The count is" to "The counter is" doesn't read as well |
Okay, then I think it's better to do revert |
|
Sounds fine to me |
|
Yep, I would prefer we keep the variable as |
count to counter in the Stores sectioncount_value to countValue in the Stores section
|
Guys, so I left only renaming |
To me, not a native English speaker, the name of the variable
counterlooks a little better in the "Stores" section because it keeps the value of the counter (not the "count" function, as I thought when I first read documentation).I also think it's better to use
camelCaseinstead ofsnake_casefor variables, so I have replacedcount_valuetocounterValuein some lines.snake_casecode style is used in a few more places, so in my opinion, it would be good to correct it as well.I will be happy to discuss this pull request