Skip to content

Conversation

@kootstra-rene
Copy link
Contributor

The #each should use the layers as defined in the <script> section so that the parallax works correctly when the layers array is changed

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

The #each should use the layers as defined in the <script> section so that the parallax works correctly when the layers array is changed
@benmccann benmccann changed the title [fix] App.svelte in window-bindings example [docs] fix #each in window-bindings example Jan 26, 2022
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the example in this PR: https://svelte.dev/examples/svelte-window-bindings

There's a tutorial with basically the same contents which matches this PR: https://svelte.dev/tutorial/svelte-window-bindings

@benmccann benmccann merged commit 4a78137 into sveltejs:master Jan 26, 2022
@kootstra-rene kootstra-rene deleted the patch-1 branch January 26, 2022 17:45
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants