Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]destroy empty component #7492

Merged
merged 13 commits into from Jul 4, 2022

Conversation

magentaqin
Copy link
Contributor

destroy empty component and fix fragment property value consistency as discussed in #7488

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@magentaqin magentaqin force-pushed the bugfix/destroy-empty-component branch from e392792 to 35da0f5 Compare April 29, 2022 08:08
@magentaqin magentaqin changed the title fix/destroy-empty-component [fix]destroy empty component Apr 30, 2022
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add test?

src/compiler/compile/render_dom/index.ts Outdated Show resolved Hide resolved
src/runtime/internal/transitions.ts Outdated Show resolved Hide resolved
@magentaqin
Copy link
Contributor Author

Could you please add test?

OK. I will add test later.

@magentaqin
Copy link
Contributor Author

@baseballyama Already pushed. Have a look at it. 🤝

src/compiler/compile/render_dom/Block.ts Outdated Show resolved Hide resolved
src/compiler/compile/render_dom/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the comments many times but I think we need to update the test!

src/runtime/internal/transitions.ts Outdated Show resolved Hide resolved
test/runtime/samples/empty-component-destroy/Empty.svelte Outdated Show resolved Hide resolved
@magentaqin
Copy link
Contributor Author

Sorry for the comments many times but I think we need to update the test!

😁 Indeed no bother at all, as concise code and better solution is what we both pursue. Thanks for your effort on careful reviewing. Already pushed. Have a look.

@magentaqin
Copy link
Contributor Author

@baseballyama Is this PR ready to merge?

@baseballyama
Copy link
Member

Yeah, it looks good to me but we need a review by at least one maintainer.

@magentaqin
Copy link
Contributor Author

Hi, @tanhauhau, could you please have a look at this PR ? I've noticed that you have committed " add typescript def for transitions (#5625)" to this file runtime/internal/transitions.ts, and this PR is related to transition_out function.

@magentaqin
Copy link
Contributor Author

Hi, @dummdidumm , could you please have a look at this PR? It's a little bugfix and has been opened for 2 months.

@baseballyama baseballyama self-requested a review July 1, 2022 03:20
@tanhauhau tanhauhau merged commit 02f60fb into sveltejs:master Jul 4, 2022
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants