Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] don't emit deprecation warning for now #8012

Merged
merged 5 commits into from Nov 10, 2022

Conversation

dummdidumm
Copy link
Member

Fixes #8009

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@mallsoft
Copy link

If you supress this, i would add that it pertains to more than just the component responsible.

All in all i would probably not supress, and instead figure out why it emit's the error in the first place, even tho all defaults are kept (this should be "injected" and not false iirc).

@dummdidumm
Copy link
Member Author

dummdidumm commented Nov 10, 2022

It's vite-plugin-svelte which sets this depending on some conditions, which is why you're seing this. v-p-s can't not set this and also can't just switch to the new config option because that doesn't exist in older versions.
We also don't really know yet how compiler options would look like for version 4, so this could all change anyway.

src/compiler/compile/index.ts Outdated Show resolved Hide resolved
@dummdidumm dummdidumm changed the title [fix] emit deprecation warning only once [fix] don't emit deprecation warning for now Nov 10, 2022
@Conduitry Conduitry merged commit f4779ee into sveltejs:master Nov 10, 2022
7 checks passed
@dummdidumm dummdidumm deleted the warnings-spam branch November 10, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant console spam about "options.css"
4 participants