Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] util polyfill to make compiler self-contained #8014

Merged
merged 3 commits into from Nov 10, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 10, 2022

this is needed for running the Svelte compiler in the browser again. Some package requires the builtin 'node' package which isn't bundled but also not available in the browser, so the REPL is broken. This slipped in through some dependency bump I guess.
Fixes #8010

I decided against using rollup-plugin-node-builtins because that one's quite outdated and ships a bunch of stuff we don't need

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

this is needed for running the Svelte compiler in the browser
Fixes sveltejs#8010
@Conduitry Conduitry merged commit e48fa4a into sveltejs:master Nov 10, 2022
22 checks passed
@dummdidumm dummdidumm deleted the util-polyfill branch November 10, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte.dev/repl is broken with the latest compiler v3.53.0
2 participants