Skip to content

Conversation

@indranilchak
Copy link

There might be cases where there are properties that are read-only and setting their value would trigger an exception. Address that by querying the descriptor and figuring out if the property is writable.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

There might be cases where there are properties that are read-only and
setting their value would trigger an exception. Address that by querying
the descriptor and figuring out if the property is writable.
@vercel
Copy link

vercel bot commented Feb 28, 2023

Someone is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

dummdidumm commented Mar 1, 2023

Could you give an example where that happens, and why it's not circumventable by just not setting that property as a dev?

@baseballyama baseballyama added the awaiting submitter needs a reproduction, or clarification label Mar 1, 2023
@dummdidumm dummdidumm added this to the one day milestone Mar 29, 2023
@Rich-Harris
Copy link
Member

Closing as it's not clear which properties this pertains to

@Rich-Harris Rich-Harris closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting submitter needs a reproduction, or clarification custom element

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants