From 58159faebc3e24b9239fe47badd89c16a127b45b Mon Sep 17 00:00:00 2001 From: Puru Vijay Date: Sat, 10 Jun 2023 15:25:34 +0530 Subject: [PATCH 1/5] Push --- sites/svelte.dev/src/routes/docs/+layout.server.js | 4 ++-- sites/svelte.dev/src/routes/docs/+layout.svelte | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sites/svelte.dev/src/routes/docs/+layout.server.js b/sites/svelte.dev/src/routes/docs/+layout.server.js index ff3acad12540..0be275db144d 100644 --- a/sites/svelte.dev/src/routes/docs/+layout.server.js +++ b/sites/svelte.dev/src/routes/docs/+layout.server.js @@ -2,8 +2,8 @@ import { get_docs_data, get_docs_list } from '$lib/server/docs/index.js'; export const prerender = true; -export function load() { +export function load({ url }) { return { - sections: get_docs_list(get_docs_data()) + sections: url.pathname === '/docs' ? [] : get_docs_list(get_docs_data()) }; } diff --git a/sites/svelte.dev/src/routes/docs/+layout.svelte b/sites/svelte.dev/src/routes/docs/+layout.svelte index d47b170a678b..b097119de77c 100644 --- a/sites/svelte.dev/src/routes/docs/+layout.svelte +++ b/sites/svelte.dev/src/routes/docs/+layout.svelte @@ -6,7 +6,7 @@ export let data; $: title = data.sections - .find(({ pages }) => pages.find(({ path }) => path === $page.url.pathname)) + .find(({ pages }) => pages?.find(({ path }) => path === $page.url.pathname)) ?.pages.find(({ path }) => path === $page.url.pathname).title; From 51babfa6c5f9de056e4e9b5daf1b91f72a1a084d Mon Sep 17 00:00:00 2001 From: Puru Vijay Date: Sat, 10 Jun 2023 15:27:00 +0530 Subject: [PATCH 2/5] ssr = false --- sites/svelte.dev/src/routes/docs/+layout.server.js | 4 ++-- sites/svelte.dev/src/routes/docs/+page.server.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sites/svelte.dev/src/routes/docs/+layout.server.js b/sites/svelte.dev/src/routes/docs/+layout.server.js index 0be275db144d..ff3acad12540 100644 --- a/sites/svelte.dev/src/routes/docs/+layout.server.js +++ b/sites/svelte.dev/src/routes/docs/+layout.server.js @@ -2,8 +2,8 @@ import { get_docs_data, get_docs_list } from '$lib/server/docs/index.js'; export const prerender = true; -export function load({ url }) { +export function load() { return { - sections: url.pathname === '/docs' ? [] : get_docs_list(get_docs_data()) + sections: get_docs_list(get_docs_data()) }; } diff --git a/sites/svelte.dev/src/routes/docs/+page.server.js b/sites/svelte.dev/src/routes/docs/+page.server.js index 2ac91da50730..1eeff97d0064 100644 --- a/sites/svelte.dev/src/routes/docs/+page.server.js +++ b/sites/svelte.dev/src/routes/docs/+page.server.js @@ -1,2 +1,3 @@ // This page now exists solely for redirect, prerendering triggers the `handleMissingID` export const prerender = false; +export const ssr = false; From 4fcd256d108194517ec425ceefd1dc1158de0008 Mon Sep 17 00:00:00 2001 From: Puru Vijay Date: Sat, 10 Jun 2023 15:33:23 +0530 Subject: [PATCH 3/5] csr true --- sites/svelte.dev/src/routes/docs/+page.server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/sites/svelte.dev/src/routes/docs/+page.server.js b/sites/svelte.dev/src/routes/docs/+page.server.js index 1eeff97d0064..6c4f4ef86899 100644 --- a/sites/svelte.dev/src/routes/docs/+page.server.js +++ b/sites/svelte.dev/src/routes/docs/+page.server.js @@ -1,3 +1,4 @@ // This page now exists solely for redirect, prerendering triggers the `handleMissingID` export const prerender = false; export const ssr = false; +export const csr = true; From 354c853b4e458a00e676988eb0124fd0e3807402 Mon Sep 17 00:00:00 2001 From: Puru Vijay Date: Sat, 10 Jun 2023 15:39:03 +0530 Subject: [PATCH 4/5] Try something new --- sites/svelte.dev/src/routes/docs/+page.server.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/sites/svelte.dev/src/routes/docs/+page.server.js b/sites/svelte.dev/src/routes/docs/+page.server.js index 6c4f4ef86899..74bf8791575d 100644 --- a/sites/svelte.dev/src/routes/docs/+page.server.js +++ b/sites/svelte.dev/src/routes/docs/+page.server.js @@ -1,4 +1,2 @@ // This page now exists solely for redirect, prerendering triggers the `handleMissingID` -export const prerender = false; export const ssr = false; -export const csr = true; From e40ddadfae12c902101446aaffff97e054ea7faf Mon Sep 17 00:00:00 2001 From: Puru Vijay Date: Sat, 10 Jun 2023 15:44:09 +0530 Subject: [PATCH 5/5] Og idea --- sites/svelte.dev/src/routes/docs/+layout.server.js | 4 ++-- sites/svelte.dev/src/routes/docs/+page.server.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sites/svelte.dev/src/routes/docs/+layout.server.js b/sites/svelte.dev/src/routes/docs/+layout.server.js index ff3acad12540..0be275db144d 100644 --- a/sites/svelte.dev/src/routes/docs/+layout.server.js +++ b/sites/svelte.dev/src/routes/docs/+layout.server.js @@ -2,8 +2,8 @@ import { get_docs_data, get_docs_list } from '$lib/server/docs/index.js'; export const prerender = true; -export function load() { +export function load({ url }) { return { - sections: get_docs_list(get_docs_data()) + sections: url.pathname === '/docs' ? [] : get_docs_list(get_docs_data()) }; } diff --git a/sites/svelte.dev/src/routes/docs/+page.server.js b/sites/svelte.dev/src/routes/docs/+page.server.js index 74bf8791575d..2ac91da50730 100644 --- a/sites/svelte.dev/src/routes/docs/+page.server.js +++ b/sites/svelte.dev/src/routes/docs/+page.server.js @@ -1,2 +1,2 @@ // This page now exists solely for redirect, prerendering triggers the `handleMissingID` -export const ssr = false; +export const prerender = false;