Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: On this page mobile #8782

Merged
merged 8 commits into from Jul 6, 2023
Merged

feat: On this page mobile #8782

merged 8 commits into from Jul 6, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Jun 21, 2023

Adds a OnThisPage right under the heading. Related: sveltejs/site-kit#165

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
Copy link
Member

On this page on desktop looks weird now with this change for some reason

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 22, 2023

Let's not merge it now then, it needs more brainstorming

@PuruVJ PuruVJ marked this pull request as draft June 22, 2023 12:01
@benmccann benmccann added the site label Jun 22, 2023
@PuruVJ PuruVJ marked this pull request as ready for review July 5, 2023 19:20
@PuruVJ PuruVJ requested a review from dummdidumm July 5, 2023 19:20
@geoffrich
Copy link
Member

sveltejs/site-kit#170 fixes a bug with this that would be good to address before merging

@dummdidumm dummdidumm merged commit 76baa07 into master Jul 6, 2023
7 checks passed
@dummdidumm dummdidumm deleted the feat/mobile-on-this-page branch July 6, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants