Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split $.each into $.each_keyed/$.each_indexed #9422

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 13, 2023

With Svelte 5, we load both each block reconciliation functions, making it impossible to tree shake one or the other if you don't use them. This PR changes that, ensuring we can treeshake them respectfully by breaking the compiled function into either $.each_keyed or $.each_indexed.

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 4:59pm

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 6d50b22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm changed the title fix: split $.each into $.each_keyed/$.each_indexed chore: split $.each into $.each_keyed/$.each_indexed Nov 13, 2023
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further below on line 2411 it's always doing reconcile_indexed_array, so treeshaking won't help when you're only using keyed each. Does it need to be reconcile_indexed_array there or can it use the passed in function, too?

@Rich-Harris Rich-Harris merged commit 8798f3b into main Nov 13, 2023
6 of 8 checks passed
@trueadm trueadm deleted the split-each-block branch November 13, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants