-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split $.each into $.each_keyed/$.each_indexed #9422
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6d50b22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further below on line 2411 it's always doing reconcile_indexed_array
, so treeshaking won't help when you're only using keyed each. Does it need to be reconcile_indexed_array
there or can it use the passed in function, too?
With Svelte 5, we load both each block reconciliation functions, making it impossible to tree shake one or the other if you don't use them. This PR changes that, ensuring we can treeshake them respectfully by breaking the compiled function into either
$.each_keyed
or$.each_indexed
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint