Client freeze on character select / loading screen fix

[nolt]

Root Cause: Missing #pragma pack(push, 1) around PRECEIVE_JOIN_MAP_SERVER_EXTENDED

Commit: b46d2cc1 ("fix pragma and DWORD to WORD")
File: src/source/Network/Server/WSclient.h (line ~344)

What happened

The commit removed #pragma pack(push, 1) and #pragma pack(pop) around the PRECEIVE_JOIN_MAP_SERVER_EXTENDED struct and changed DWORD Resets to BYTE Spare; WORD Resets:

- #pragma pack(push, 1)
  typedef struct
  {
      PBMSG_HEADER Header;
      ...
      BYTE         InventoryExtensions;
-     DWORD        Resets;
+     BYTE         Spare;
+     WORD         Resets;
  } PRECEIVE_JOIN_MAP_SERVER_EXTENDED, * LPPRECEIVE_JOIN_MAP_SERVER_EXTENDED;
- #pragma pack(pop)

Effect

Without #pragma pack(push, 1), the struct uses default alignment (8-byte for uint64_t). This increases sizeof(PRECEIVE_JOIN_MAP_SERVER_EXTENDED) from 92 to ~96 bytes (tail padding to the next multiple of 8).

Root cause chain

1. Server sends a packed packet (92 bytes)
2. safe_cast<> in ReceiveJoinMapServer() (WSclient.cpp:944) checks span.size() < sizeof(T) → 92 < 96 = true
3. safe_cast returns nullptr
4. Function returns false, error is silently swallowed (line 13207-13210)
5. CurrentProtocolState stays REQUEST_JOIN_MAP_SERVER
6. EnableMainRender never becomes true
7. SwapBuffers is never called
8. Client freezes on the last frame of the loading screen — user sees a hang

Fix

Restore #pragma pack(push, 1) / #pragma pack(pop) around the struct in WSclient.h. Since adjacent structs (PRECEIVE_CREATE_CHARACTER, PRECEIVE_REVIVAL_EXTENDED) also use raw casts with network data, it is safest to wrap all three in one packed block:

// Add before PRECEIVE_CREATE_CHARACTER:
#pragma pack(push, 1)

// ... PRECEIVE_CREATE_CHARACTER ...
// ... PRECEIVE_JOIN_MAP_SERVER_EXTENDED ...
// ... PRECEIVE_REVIVAL_EXTENDED ...

// Add after PRECEIVE_REVIVAL_EXTENDED:
#pragma pack(pop)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the client would hang during the loading screen due to incorrect memory alignment of network packets. By explicitly enforcing packing on specific data structures, the client can now correctly interpret the data sent by the server, preventing silent failures in the protocol state machine and allowing the rendering process to resume as expected.

Highlights

• Memory Alignment Fix: Restored #pragma pack(push, 1) and #pragma pack(pop) directives around critical network structures to ensure correct memory alignment.
• Client Stability: Resolved a client freeze issue occurring during the character selection loading screen caused by struct size mismatches.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces memory alignment packing using #pragma pack(push, 1) and #pragma pack(pop) for network-related structs in WSclient.h. Feedback indicates that the packing block is incorrectly scoped: it should be expanded to include PRECEIVE_CHARACTER_LIST_EXTENDED to prevent buffer offset drift during data parsing, and it should also encompass later structs like PCREATE_CHARACTER_EXTENDED to ensure correct sizeof calculations for safe_cast operations, which are critical for player rendering.