Pass --host and --key opts to gem release command on to the gem push command #16

Merged
merged 2 commits into from Mar 9, 2012

Projects

None yet

2 participants

@jacobo
Contributor
jacobo commented Mar 8, 2012

as requested in: #15

@jacobo
Contributor
jacobo commented Mar 8, 2012

Hold up, that doesn't exactly work in practice.... figuring out why

@jacobo jacobo opt parse happens twice with opts passed through to PushCommand, ther…
…efore values for such args must always be captured as strings
2eaee75
@jacobo
Contributor
jacobo commented Mar 8, 2012

There we go. How do you feel about this one? @dgeb + @svenfuchs

@dgeb dgeb merged commit 025498a into svenfuchs:master Mar 9, 2012
@dgeb
Collaborator
dgeb commented Mar 9, 2012

Thanks @jacobo - merged. I'm also going to incorporate these options into bump (for use with -r) before releasing a new version.

@jacobo
Contributor
jacobo commented Mar 9, 2012

thanks @dgeb, looking forward to a new release so we can start using these new flags!

@dgeb
Collaborator
dgeb commented Mar 9, 2012

@jacobo You bet. I just started, but I will try to wrap up the next release this weekend.

@dgeb
Collaborator
dgeb commented Mar 12, 2012

@jacobo I've pushed gem-release 0.2.0, which contains the new flags. Thanks again for your PR.

I had to change course with gem bump because I uncovered issue #17 as I was filling out some tests for releasing and bumping gems in the same command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment