Skip to content

Lil chain backend fix #85

Closed
wants to merge 2 commits into from

5 participants

@pyromaniac

No description provided.

@bastien
bastien commented Mar 14, 2011

+1 Was wondering why my keys were always escaped despite the escape options set to false.

@kknapik
Collaborator
kknapik commented Mar 14, 2011

Can you please add a test as well ? :)

@pyromaniac

I can, but what should i test? Or it was a joke?

@kknapik
Collaborator
kknapik commented Mar 16, 2011

Not joking this time :) Just add a simple test for your fix, which ensure that "options are not dropped while transfering to backend". Thx!

@nhocki
nhocki commented Mar 24, 2011

+1 Please merge this :-)

@kknapik kknapik closed this Mar 24, 2011
@kknapik
Collaborator
kknapik commented Mar 24, 2011

Sorry for the dealy. Pushed. Thanks for fix!

@tmaximini

what do i need to do in order to get it working? my backendchain (redis, simple) is still not accepting any escape option and still escaping the "." dots in my key string...

@nhocki
nhocki commented Jul 1, 2011

This was pushed but a new gem version (0.5.1) was never released so the patch is not working for rails.

I did the most horrible thing though... created an initializer with this:

module I18n
  module Backend
    class Chain
      module Implementation
        def store_translations(locale, data, options = {})
          backends.first.store_translations(locale, data, options)
        end
      end
    end
  end
end

That fixes the problem =/

@pyromaniac

Holy crap. This is really sad. I'll try to patch it arain soon ) They just forgot about chis patch (

@nhocki
nhocki commented Jul 1, 2011

Yeah, I reported this on #100 ... there's a bundler fix posted by @knapo

@tmaximini

ah ok, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.