Lil chain backend fix #85

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
@pyromaniac

No description provided.

@bastien

This comment has been minimized.

Show comment
Hide comment
@bastien

bastien Mar 14, 2011

+1 Was wondering why my keys were always escaped despite the escape options set to false.

bastien commented Mar 14, 2011

+1 Was wondering why my keys were always escaped despite the escape options set to false.

@knapo

This comment has been minimized.

Show comment
Hide comment
@knapo

knapo Mar 14, 2011

Collaborator

Can you please add a test as well ? :)

Collaborator

knapo commented Mar 14, 2011

Can you please add a test as well ? :)

@pyromaniac

This comment has been minimized.

Show comment
Hide comment
@pyromaniac

pyromaniac Mar 15, 2011

I can, but what should i test? Or it was a joke?

I can, but what should i test? Or it was a joke?

@knapo

This comment has been minimized.

Show comment
Hide comment
@knapo

knapo Mar 16, 2011

Collaborator

Not joking this time :) Just add a simple test for your fix, which ensure that "options are not dropped while transfering to backend". Thx!

Collaborator

knapo commented Mar 16, 2011

Not joking this time :) Just add a simple test for your fix, which ensure that "options are not dropped while transfering to backend". Thx!

@nhocki

This comment has been minimized.

Show comment
Hide comment
@nhocki

nhocki Mar 24, 2011

+1 Please merge this :-)

nhocki commented Mar 24, 2011

+1 Please merge this :-)

@knapo knapo closed this Mar 24, 2011

@knapo

This comment has been minimized.

Show comment
Hide comment
@knapo

knapo Mar 24, 2011

Collaborator

Sorry for the dealy. Pushed. Thanks for fix!

Collaborator

knapo commented Mar 24, 2011

Sorry for the dealy. Pushed. Thanks for fix!

@tmaximini

This comment has been minimized.

Show comment
Hide comment
@tmaximini

tmaximini Jul 1, 2011

what do i need to do in order to get it working? my backendchain (redis, simple) is still not accepting any escape option and still escaping the "." dots in my key string...

what do i need to do in order to get it working? my backendchain (redis, simple) is still not accepting any escape option and still escaping the "." dots in my key string...

@nhocki

This comment has been minimized.

Show comment
Hide comment
@nhocki

nhocki Jul 1, 2011

This was pushed but a new gem version (0.5.1) was never released so the patch is not working for rails.

I did the most horrible thing though... created an initializer with this:

module I18n
  module Backend
    class Chain
      module Implementation
        def store_translations(locale, data, options = {})
          backends.first.store_translations(locale, data, options)
        end
      end
    end
  end
end

That fixes the problem =/

nhocki commented Jul 1, 2011

This was pushed but a new gem version (0.5.1) was never released so the patch is not working for rails.

I did the most horrible thing though... created an initializer with this:

module I18n
  module Backend
    class Chain
      module Implementation
        def store_translations(locale, data, options = {})
          backends.first.store_translations(locale, data, options)
        end
      end
    end
  end
end

That fixes the problem =/

@pyromaniac

This comment has been minimized.

Show comment
Hide comment
@pyromaniac

pyromaniac Jul 1, 2011

Holy crap. This is really sad. I'll try to patch it arain soon ) They just forgot about chis patch (

Holy crap. This is really sad. I'll try to patch it arain soon ) They just forgot about chis patch (

@nhocki

This comment has been minimized.

Show comment
Hide comment
@nhocki

nhocki Jul 1, 2011

Yeah, I reported this on #100 ... there's a bundler fix posted by @knapo

nhocki commented Jul 1, 2011

Yeah, I reported this on #100 ... there's a bundler fix posted by @knapo

@tmaximini

This comment has been minimized.

Show comment
Hide comment
@tmaximini

tmaximini Jul 1, 2011

ah ok, thanks for the heads up

ah ok, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment