Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lil chain backend fix #85

Closed
wants to merge 2 commits into from
Closed

Lil chain backend fix #85

wants to merge 2 commits into from

Conversation

pyromaniac
Copy link
Contributor

No description provided.

@bastien
Copy link

bastien commented Mar 14, 2011

+1 Was wondering why my keys were always escaped despite the escape options set to false.

@knapo
Copy link
Collaborator

knapo commented Mar 14, 2011

Can you please add a test as well ? :)

@pyromaniac
Copy link
Contributor Author

I can, but what should i test? Or it was a joke?

@knapo
Copy link
Collaborator

knapo commented Mar 16, 2011

Not joking this time :) Just add a simple test for your fix, which ensure that "options are not dropped while transfering to backend". Thx!

@nhocki
Copy link

nhocki commented Mar 24, 2011

+1 Please merge this :-)

@knapo knapo closed this Mar 24, 2011
@knapo
Copy link
Collaborator

knapo commented Mar 24, 2011

Sorry for the dealy. Pushed. Thanks for fix!

@tmaximini
Copy link

what do i need to do in order to get it working? my backendchain (redis, simple) is still not accepting any escape option and still escaping the "." dots in my key string...

@nhocki
Copy link

nhocki commented Jul 1, 2011

This was pushed but a new gem version (0.5.1) was never released so the patch is not working for rails.

I did the most horrible thing though... created an initializer with this:

module I18n
  module Backend
    class Chain
      module Implementation
        def store_translations(locale, data, options = {})
          backends.first.store_translations(locale, data, options)
        end
      end
    end
  end
end

That fixes the problem =/

@pyromaniac
Copy link
Contributor Author

Holy crap. This is really sad. I'll try to patch it arain soon ) They just forgot about chis patch (

@nhocki
Copy link

nhocki commented Jul 1, 2011

Yeah, I reported this on #100 ... there's a bundler fix posted by @knapo

@tmaximini
Copy link

ah ok, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants