rake spec fails on Ruby 1.8.7 #210

Closed
kuroda opened this Issue Mar 25, 2012 · 14 comments

Projects

None yet

4 participants

@kuroda
Collaborator
kuroda commented Mar 25, 2012

On Ruby 1.8.7, I got following result:

% rake spec --trace
rake aborted!
no such file to load -- psych
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/i18n-spec-0.1.2/lib/i18n-spec.rb:1
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/i18n-spec-0.1.2/lib/i18n-spec/tasks.rb:1
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:60:in `gem_original_require'
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:60:in `require'
/home/kuroda/github/rails-i18n/repo/Rakefile:34
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:501:in `raw_load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:82:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:81:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:65:in `run'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/bin/rake:33
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/bin/rake:19:in `load'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/bin/rake:19

I want to run a test on Ruby 1.8.7 in order to fix #208. Please help.

@nashbridges
Contributor

i18n-spec directly requires psych, which is 1.9 only. We need help of @tigrish.

@hron84
Contributor
hron84 commented Mar 25, 2012

@kuroda could you please check specs works agains https://github.com/hron84/i18n-spec on develop branch? (This contains two pull request what I sent to @tigrish about supporting i18n-spec on all supported MRI versions).

Temporarily put this to Gemfile:

gem 'i18n-spec', :git => "git://github.com/hron84/i18n-spec.git", :branch => 'develop'

it should need to fix your problem - until @tigrish merges my patches.

@kuroda
Collaborator
kuroda commented Mar 26, 2012

@hron84

Unfortunately, I got following result:

rake spec --trace                                                                                                   [~/github/rails-i18n/repo]
rake aborted!
no such file to load -- i18n-spec/tasks
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
/home/kuroda/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
/home/kuroda/github/rails-i18n/repo/Rakefile:34
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:501:in `raw_load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:82:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:81:in `load_rakefile'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:65:in `run'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/gems/rake-0.9.2.2/bin/rake:33
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/bin/rake:19:in `load'
/home/kuroda/.rvm/gems/ruby-1.8.7-p358/bin/rake:19

Could you help me?

@hron84
Contributor
hron84 commented Mar 27, 2012

@kuroda Try bundle exec rake spec

@kuroda
Collaborator
kuroda commented Mar 28, 2012

@hron84 Thanks.

I made a fix for Ruby 1.8 (b42bbba) and all spec examples passed both in Ruby 1.9 and 1.8.

But I am getting following warning:

/home/kuroda/.rvm/gems/ruby-1.8.7-p358@rails-i18n/gems/i18n-spec-0.2.0/lib/i18n-spec/matchers/have_legacy_interpolations.rb:1: warning: multiple values for a block parameter (0 for 1)
from /home/kuroda/.rvm/gems/ruby-1.8.7-p358@rails-i18n/gems/rspec-expectations-2.9.0/lib/rspec/matchers/extensions/instance_eval_with_args.rb:11

I don't get any warning on Ruby 1.9.

I'm not sure if this warning is derived form i18n-spec or from my patch. Can you have a look?

@kuroda kuroda closed this Mar 28, 2012
@hron84
Contributor
hron84 commented Mar 28, 2012

@kuroda this warning comes from i18n-spec and it is a known problem. However I do not have an idea how to solve it, because this problem is on rspec side. I decided to not solve this issue until it is being stopper. I do not know @tigrish will or will not pay attention for this.

@kuroda
Collaborator
kuroda commented Mar 28, 2012

I see. Thank for a reply.

@tigrish
Contributor
tigrish commented Mar 29, 2012

I'll have a look into this warning, but no guarantees that it will get fixed for 1.8 .

@kuroda
Collaborator
kuroda commented Mar 29, 2012

@nashbridges

Unfortunately, I still see same warnings.

@hron84
Contributor
hron84 commented Mar 29, 2012

@kuroda I think @nashbridges updated gemspec for get support for 1.8 not for shut up warnings :-)

@kuroda
Collaborator
kuroda commented Mar 29, 2012

@hron84 I see.

@tigrish
Contributor
tigrish commented Apr 2, 2012

FYI @kuroda deprecation warnings have been fixed in i18n-spec v0.2.1 for ruby 1.8

@kuroda
Collaborator
kuroda commented Apr 2, 2012

@tigrish Confirmed. I got no warnings on Ruby 1.8. Thanks a lot.

@hron84
Contributor
hron84 commented Apr 3, 2012

@tigrish thanks your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment