Serbian Cyrillic: Fix date format, February typo, and RSD unit#1140
Merged
Conversation
Collaborator
|
Can you also add an entry to the CHANGELOG please? 🙏🏻 |
Contributor
Author
|
done that @pama |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the library.
I noticed that date formatting is off for Serbian, so this PR changes that.
How to format a date:
https://www.opismenise.com/nedoumice/kako-se-pise-datum-u-srpskom-jeziku/
I also changed unit to
РСДbecause that's what people use in cyrillic now. For international use there is RSD which is also its' ISO code.This is a screenshot from the app where I pay for electricity to prove the point.
The next step would be adding a sr-el encoding and renaming sr to sr-ec, because Serbian allows two alphabets.