Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

hr and sr fixes #265

Merged
merged 2 commits into from Oct 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

dmilisic commented Oct 4, 2012

  • reverted sr-Latn - scr language does not exist for more than 20 years - sr-Latn is the same serbian language written in cyrillic script
  • east slavic "one" pluralization is also used for 21, 31, etc. so I inserted %{count} instead of 1
Collaborator

kuroda commented Oct 4, 2012

@dmilisic I can't merge your pull request because it breaks a test case.

The cause of failure is that sr-Latn locale is not included in the list of iso gem, which is maintained by @tigrish. See https://github.com/tigrish/iso/blob/master/data/iso-639-1.yml.

So, I propose you the following:

  • Divide this commit into two: one is for hr and another is for sr-Latn. I will merge the former immediately.
  • Consult @tigrish to include sr-Latn as a valid locale name.
  • Send us another pull request including sr-Latn reversion.
Contributor

tigrish commented Oct 4, 2012

Good stuff re: hr and sr pluralizations and a great example of why hard encoding 1 into the translations is a bad idea.

Any interest in implementing ISO 15924 into the iso gem? I've shied away from it because sr-Latn was the only locale that depended on it. This list seems pretty complete : http://unicode.org/iso15924/iso15924-codes.html

Also, does this mean that sr should be renamed to sr-Cyrl or is that standard and obvious to most serbian speakers? (my view is that shorter locale codes are best).

Contributor

dmilisic commented Oct 5, 2012

I reverted sr-Latn to scr for now... In all tree locales, one pluralizations are fixed. I will see what can be done with serbian Cyrillic an Latin scripts...

As I found out:

Cyrillic and Latin script are equal by the grammar and spelling of the Serbian language. Both scripts are treated equally everywhere except in the state administration, which favors Cyrillic in government documents by a constitutional act.

kuroda added a commit that referenced this pull request Oct 5, 2012

@kuroda kuroda merged commit 855edc0 into svenfuchs:master Oct 5, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment