[WIP] Check timestamps before overwriting them #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| obj.state = target_state(data) | ||
| end | ||
|
|
||
| def set_attr(obj, key, value) | ||
| obj.send(:"#{key}=", value) if obj.respond_to?(:"#{key}=") | ||
| end | ||
|
|
||
| def set_timestamp?(key, target_state_attr) | ||
| key == target_state_attr || key == "finished_at" || !key.end_with?('at') |
There was a problem hiding this comment.
Should this condition (key == "finished_at") be more generic ?
anarosas
force-pushed
the
ar-check-set-timestamps
branch
from
952c87c
to
6d95dfc
Compare
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of timestamps (started_at) are overwritten during the finish state. Mainly because a new timestamp is passed on the attributes.
We should validate first that we really want to accept these new timestamp by comparing the key name to the
target_stateor checking if the current key is for thefinished_atattribute