forked from andy-shev/linux
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add kernel parameter to enable i2c-6 pinctrl mapping
By default the pinctrl platform driver for Merrifield will register a pinctrl mapping for i2c-6 that sets the correct pinmux once i2c-6 is probed. If this is not desired, the following can be added to the kernel command line: platform_mrfld_pinctrl.pinctrl_i2c6=n Since the SCU driver is probed after the I2C bus drivers (due to the order of PCI IDs), setting the pinmux for i2c-6 will fail since the SCU driver must be probed to successfully set the bufcfg. As a workaround, the I2C bus driver (i2c-designware-pci) can be compiled as a LKM and inserted after all other PCI devices have been probed.
- Loading branch information
1 parent
54f9552
commit 19dc842
Showing
2 changed files
with
39 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19dc842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding a root cause why it wasn't working!
Though, looking to above change makes me clear that it should be done rather in U-Boot.
19dc842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, there are macros to help filling mappings structure http://elixir.free-electrons.com/linux/latest/source/include/linux/pinctrl/machine.h#L88
19dc842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't deny that this is a hack ;)
I am aware of the macros, but I had to go back and forth a lot and not using the macro gave me some extra agility. For some reason, I never went back to using the macro.
19dc842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TWIMC, I2C mode has been "fixed" thru U-Boot: u-boot/u-boot@f26b260