Generate at least one page, issue #52#53
Merged
sverrirs merged 2 commits intosverrirs:masterfrom Dec 2, 2017
Merged
Conversation
ashmaroli
reviewed
Dec 1, 2017
| # In case there are no (visible) posts, generate the index file anyway | ||
| if total_pages == 0 | ||
| total_pages = 1 | ||
| end |
Contributor
There was a problem hiding this comment.
in one line.
total_pages = 1 if total_pages.zero?
Contributor
Author
There was a problem hiding this comment.
Ok! Those were actually the first lines of Ruby I'd ever written... 😊
Owner
|
Now that is an excellent fix :) short and sweet ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where there are no posts (fresh site) or all the posts are hidden, no
index.htmlis generated at the document root, leading to 404 errors from many/most hosting providers. This patch makes paginate-v2 always generate at least 1 page.This fixes issue #52