Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated colorNames according to CSS Color Module Level 4 #755

Merged
merged 5 commits into from Sep 14, 2017

Conversation

ydaniv
Copy link
Contributor

@ydaniv ydaniv commented Jul 5, 2017

Mostly missing variants of gray/grey and added rebeccapurple.

@ydaniv ydaniv changed the title Fix gray grey names Updated colorNames according to CSS Color Module Level 4 Jul 5, 2017
@ydaniv
Copy link
Contributor Author

ydaniv commented Jul 5, 2017

Should note that currently colorsNames contain values in short hex format, which currently goes against current API description and docs, which state that it will translate color names to long hex.

I'd gladly add a commit that fixes all of these to long format if there's no objection.

@Yeti-or
Copy link
Contributor

Yeti-or commented Jul 6, 2017

convertColors plugin choose what is shorter rgb() hex or name. So I think that docs are correct right now

@ydaniv
Copy link
Contributor Author

ydaniv commented Jul 9, 2017

@Yeti-or yes, took me awhile to figure out the purpose of all the different collections (:
but the problem is that if you set the config to:

shorthex: false
shortname: false

You'll expect all hexes to be in long format, but they won't.

And besides, there are some valid color names from the specs that are missing.

@GreLI GreLI merged commit 87796ac into svg:master Sep 14, 2017
@ydaniv
Copy link
Contributor Author

ydaniv commented Sep 14, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants