New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.2 Shift #13

Merged
merged 9 commits into from Nov 21, 2016

Conversation

Projects
None yet
3 participants
@laravel-shift
Contributor

laravel-shift commented Nov 21, 2016

This pull request includes the changes for upgrading to Laravel 5.2. Feel free to commit any additional changes to the laravel-5.2-shift branch.

Before merging, you should:

  • Checkout the laravel-5.2-shift branch
  • Review all pull request comments for additional changes
  • Run composer update (if the pre-commands fail, add --no-scripts)
  • Thoroughly test your application

If you would like more help with your upgrade, check out the new human services from Laravel Shift.

laravel-shift added some commits Nov 21, 2016

Adopt PSR-2 coding style
The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
Adopt PHP short array syntax
Laravel 5 adopted the short array syntax which became available in
PHP 5.4.
Shift Authentication
Laravel 5.2 introduces a *Guard* object to the Authentication
component. In doing so, the configuration options and default
Middleware changed.
Shift Middleware
Laravel 5.2 adjusts the `Guard` object used within middleware. In
addition, new `can` and `throttles` middleware were added.
@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

Laravel 5.2 modified the default Middleware. Since your middleware differs from the Laravel 5.1 default, you will need to compare the following middleware against the 5.2 versions and merge any changes.

  • app/Http/Middleware/Authenticate.php
  • app/Http/Middleware/RedirectIfAuthenticated.php
Contributor

laravel-shift commented Nov 21, 2016

Laravel 5.2 modified the default Middleware. Since your middleware differs from the Laravel 5.1 default, you will need to compare the following middleware against the 5.2 versions and merge any changes.

  • app/Http/Middleware/Authenticate.php
  • app/Http/Middleware/RedirectIfAuthenticated.php
@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

⚠ Laravel 5.2 adds Middleware Groups for convenience. Since this may affect your routes and controllers, I did not automate this upgrade. You should read about Middleware Groups to understand this change.

When you are ready to upgrade to Middleware Groups, you should:

  • Compare your app/Http/Kernel.php with the 5.2 version
  • Compare your app/Providers/RouteServiceProvider.php with the 5.2 version
  • Review any usages of the web middleware within your application
Contributor

laravel-shift commented Nov 21, 2016

⚠ Laravel 5.2 adds Middleware Groups for convenience. Since this may affect your routes and controllers, I did not automate this upgrade. You should read about Middleware Groups to understand this change.

When you are ready to upgrade to Middleware Groups, you should:

  • Compare your app/Http/Kernel.php with the 5.2 version
  • Compare your app/Providers/RouteServiceProvider.php with the 5.2 version
  • Review any usages of the web middleware within your application
@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

ℹ Laravel 5.2 changed the value of $redirectTo from /home to / in app/Http/Controllers/Auth/AuthController.php. I did not make this change since you may have customized it for your app. However, you may wish to change this if you are not using Auth or if you want to follow the latest Laravel conventions.

Contributor

laravel-shift commented Nov 21, 2016

ℹ Laravel 5.2 changed the value of $redirectTo from /home to / in app/Http/Controllers/Auth/AuthController.php. I did not make this change since you may have customized it for your app. However, you may wish to change this if you are not using Auth or if you want to follow the latest Laravel conventions.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

Laravel 5.2 condenses the default User model dramatically. Since your app/User.php differs from the Laravel 5.1 default, you will need to compare yours against the 5.2 version and merge any changes.

Contributor

laravel-shift commented Nov 21, 2016

Laravel 5.2 condenses the default User model dramatically. Since your app/User.php differs from the Laravel 5.1 default, you will need to compare yours against the 5.2 version and merge any changes.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

ℹ Laravel 5.2 updated the database session driver. If you are using the database driver, you need to add the user_id (nullable integer), ip_address (nullable string), and user_agent (text) columns to your session database table.

Contributor

laravel-shift commented Nov 21, 2016

ℹ Laravel 5.2 updated the database session driver. If you are using the database driver, you need to add the user_id (nullable integer), ip_address (nullable string), and user_agent (text) columns to your session database table.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

⚠ I was unable to update phpunit.xml since yours differed from the Laravel default. You need to compare your phpunit.xml with the Laravel 5.2 version and merge any changes.

Contributor

laravel-shift commented Nov 21, 2016

⚠ I was unable to update phpunit.xml since yours differed from the Laravel default. You need to compare your phpunit.xml with the Laravel 5.2 version and merge any changes.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

Laravel 5.2 updated some of the default validation messages. Since your resources/lang/en/validation.php differed from the Laravel default, you need to review the Laravel 5.2 version and merge any changes.

Contributor

laravel-shift commented Nov 21, 2016

Laravel 5.2 updated some of the default validation messages. Since your resources/lang/en/validation.php differed from the Laravel default, you need to review the Laravel 5.2 version and merge any changes.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

ℹ Laravel 5.2 added the env configuration option. Laravel strongly recommends you only use env() from configuration files and use config() within your app.

I found potential uses of env() in:

  • app/Console/Commands/ProcessTweets.php
Contributor

laravel-shift commented Nov 21, 2016

ℹ Laravel 5.2 added the env configuration option. Laravel strongly recommends you only use env() from configuration files and use config() within your app.

I found potential uses of env() in:

  • app/Console/Commands/ProcessTweets.php
@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

I could not upgrade the following configuration files since they differed from the 5.1 defaults. You need to compare these configuration files against the default Laravel 5.2 configuration files and merge any changes:

  • config/broadcasting.php
  • config/database.php
  • config/mail.php
  • config/queue.php
Contributor

laravel-shift commented Nov 21, 2016

I could not upgrade the following configuration files since they differed from the 5.1 defaults. You need to compare these configuration files against the default Laravel 5.2 configuration files and merge any changes:

  • config/broadcasting.php
  • config/database.php
  • config/mail.php
  • config/queue.php
@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

ℹ Laravel 5.2 removed the pretend mail configuration option. If you were using pretend, use the log driver instead.

Contributor

laravel-shift commented Nov 21, 2016

ℹ Laravel 5.2 removed the pretend mail configuration option. If you were using pretend, use the log driver instead.

@laravel-shift

This comment has been minimized.

Show comment
Hide comment
@laravel-shift

laravel-shift Nov 21, 2016

Contributor

⚠ Laravel 5.2 upgraded some of the Node package dependencies. You should to compare your package.json with the Laravel 5.2 version to update your dependencies.

Contributor

laravel-shift commented Nov 21, 2016

⚠ Laravel 5.2 upgraded some of the Node package dependencies. You should to compare your package.json with the Laravel 5.2 version to update your dependencies.

@svpernova09 svpernova09 merged commit 992261b into master Nov 21, 2016

@jasonmccreary

This comment has been minimized.

Show comment
Hide comment
@jasonmccreary

jasonmccreary commented Nov 22, 2016

@svpernova09 how did it go?

@svpernova09

This comment has been minimized.

Show comment
Hide comment
@svpernova09

svpernova09 Nov 22, 2016

Owner

@jasonmccreary went well, the comments with links to update the files to default values was great. Really made it easy to go through and update everything.

Owner

svpernova09 commented Nov 22, 2016

@jasonmccreary went well, the comments with links to update the files to default values was great. Really made it easy to go through and update everything.

@svpernova09 svpernova09 deleted the laravel-5.2-shift branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment