Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature export SonosEventListener #123

Merged
merged 2 commits into from Jan 22, 2021
Merged

feature export SonosEventListener #123

merged 2 commits into from Jan 22, 2021

Conversation

hklages
Copy link
Contributor

@hklages hklages commented Jan 22, 2021

export SonosEventListener

Description

export SonosEventListener to be able to change the default settings

Please check - I am not able to test it and have NO TypeScript knowledge - just following your patttern.

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

馃挃 Thank you!

@coveralls
Copy link

coveralls commented Jan 22, 2021

Pull Request Test Coverage Report for Build 503433145

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 78.463%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/index.ts 1 0%
Totals Coverage Status
Change from base Build 494113710: -0.05%
Covered Lines: 1419
Relevant Lines: 1815

馃挍 - Coveralls

@hklages
Copy link
Contributor Author

hklages commented Jan 22, 2021

added the missing semicolon

@svrooij svrooij merged commit 3a72c5e into svrooij:beta Jan 22, 2021
@github-actions
Copy link

馃帀 This PR is included in version 2.4.0-beta.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions
Copy link

馃帀 This PR is included in version 2.4.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants