[objc] Add casts that avoid method resolution errors for count

[ches]

Because the data that we're deserializing is of type id (essentially untyped), it's possible to have method resolution clashes without explicitly casting here once we've sufficiently parsed a type. I had this issue with a pagination container model, for instance, which has a field named count that conflicts with the property of the same name on NSArray or NSDictionary, preventing the code from compiling until I made this change.

[wing328]

@ches thanks for the PR. Do you mind sharing the spec for reproducing the issue?

[ches]

The actual spec is private and is rather complicated to reduce to a minimal example (the API is JSON API-compliant and the Swagger spec models basically the entire JSON Schema of the spec's container structures, etc.), but I think this part is enough to create a reproduction case:

definitions:
  PaginatedResourcesResponse:
    description: A successful collection response with pagination metadata.
    allOf:
      - $ref: '#/definitions/SuccessResponseCollection'
      - properties:
          meta:
            type: object
            properties:
              pagination:
                $ref: '#/definitions/PaginationMetadata'

  PaginationMetadata:
    properties:
      count:
        description: Number of results in current page.
        type: integer
      total:
        description: Total number of results available.
        type: integer
      total_pages:
        type: integer
      per_page:
        type: integer
      current_page:
        type: integer
      links:
        type: object
        properties:
          next:
            title: URL for the next page of results.
            type: string
            format: url
          previous:
            title: URL for the previous page of results.
            type: string
            format: url

Nevermind the elided SuccessResponseCollection, substitute anything for that. The salient part is that PaginationMetadata has a property called count. Without this patch, data is an ObjC id, and the compiler can't figure out which count method should be dispatched, it clashes with the count properties on NSArray, NSDictionary, etc.

[wing328]

@ches thanks for the details in reproducing the issue. I'll use it to confirm and let you know if I've further questions on the PR.

[ches]

cc @geekerzp perhaps who has done much of the ObjC client work it seems.

[wing328]

Was able to repeat the issue and integration test in your branch looks good:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.464 s
[INFO] Finished at: 2015-10-09T16:40:35+08:00
[INFO] Final Memory: 11M/245M
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.464 s
[INFO] Finished at: 2015-10-09T16:40:35+08:00
[INFO] Final Memory: 11M/245M
[INFO] ------------------------------------------------------------------------

[ches]

Thanks! I think I will have some more fixes for ObjC on the way soon 😃

[wing328]

Thanks @ches

To run the ObjC integration test locally, please execute the following commands in the project root directory:

./bin/objc-petstore.sh
cd samples/client/petstore/objc/SwaggerClientTests 
mvn integration-test -rf :ObjcPetstoreClientTests