Code generator for haskell-servant framework #2009

Merged
merged 4 commits into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@algas
Contributor

algas commented Jan 31, 2016

No description provided.

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Jan 31, 2016

Contributor

@algas thanks for the PR! 🍻

One suggestion is to rename haskell to haskell-servant instead as developers may confuse haskell with the Haskell API client. (we'd the issue with nodejs in which developers expected a Nodejs API client but nodejs refers to Nodejs server generator instead)

Contributor

wing328 commented Jan 31, 2016

@algas thanks for the PR! 🍻

One suggestion is to rename haskell to haskell-servant instead as developers may confuse haskell with the Haskell API client. (we'd the issue with nodejs in which developers expected a Nodejs API client but nodejs refers to Nodejs server generator instead)

@algas

This comment has been minimized.

Show comment
Hide comment
@algas

algas Jan 31, 2016

Contributor

@wing328 Thank you for your advice. I renamed it.

Contributor

algas commented Jan 31, 2016

@wing328 Thank you for your advice. I renamed it.

bin/haskell-petstore.sh
+
+# if you've executed sbt assembly previously it will use that instead.
+export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties"
+ags="$@ generate -t modules/swagger-codegen/src/main/resources/haskell -i modules/swagger-codegen/src/test/resources/2_0/petstore.json -l haskell -o samples/server/petstore/haskell"

This comment has been minimized.

@wing328

wing328 Jan 31, 2016

Contributor

@algas should -l haskell be renamed to -l hashkell-servant and samples/server/petstore/haskell be renamed to samples/server/petstore/haskell-servant?

@wing328

wing328 Jan 31, 2016

Contributor

@algas should -l haskell be renamed to -l hashkell-servant and samples/server/petstore/haskell be renamed to samples/server/petstore/haskell-servant?

wing328 added a commit that referenced this pull request Feb 1, 2016

Merge pull request #2009 from algas/support-haskell
Code generator for haskell-servant framework

@wing328 wing328 merged commit 70cce74 into swagger-api:master Feb 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Feb 1, 2016

Contributor

PR merged. Thanks again for the contribution.

Contributor

wing328 commented Feb 1, 2016

PR merged. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment