Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] Added 'modelPropertyNaming' option for Scala #3685

Merged
merged 3 commits into from Sep 1, 2016

Conversation

Projects
None yet
2 participants
@arpitkulria
Copy link
Contributor

commented Aug 31, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

arpitkulria added some commits Aug 31, 2016

Closed #3675
1. Added 'modelPropertyNaming' option for scala
2. Executed ./bin/scala-petstore.sh (no changes).

@arpitkulria arpitkulria referenced this pull request Aug 31, 2016

Closed

Added 'modelPropertyNaming' option for Scala #3676

3 of 3 tasks complete
@wing328

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2016

@arpitkulria the change looks good. Thanks for the contribution.

@wing328 wing328 merged commit e7ec360 into swagger-api:master Sep 1, 2016

3 checks passed

Shippable Run 279 status is SUCCESS.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arpitkulria

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

@wing328 Thanks :)

@wing328 wing328 added this to the v2.2.2 milestone Sep 1, 2016

acramatte added a commit to comerge/swagger-codegen that referenced this pull request Sep 5, 2016

Merge branch 'master' of https://github.com/swagger-api/swagger-codegen
* 'master' of https://github.com/swagger-api/swagger-codegen:
  Issue swagger-api#3687 silence resty logging [Go] (swagger-api#3705)
  update ruby regular expression to use \A
  [Ruby] Fix ambiguous regex (swagger-api#3716)
  [PHP] Corrected PHPDoc type declarations (swagger-api#3710)
  Python collection formatting fixes/support (swagger-api#3697)
  php: Fix syntax error when pattern contains a single quote
  ruby: Fix syntax error when pattern contains a single quote
  [Scalatra] replace {} with : in scalatra path (swagger-api#3694)
  java: Javadoc fixes
  Spelling fixes
  Added 'modelPropertyNaming' option for Scala (swagger-api#3685)
  Added functionality to handle optional parameters for Scala (swagger-api#3683)
  Python fixes (swagger-api#3689)

@wing328 wing328 changed the title Added 'modelPropertyNaming' option for Scala [Scala] Added 'modelPropertyNaming' option for Scala Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.