Allow Java source formatting mvn formatter:format #4214
Conversation
nickcmaynard
referenced
this pull request
Nov 18, 2016
Open
DISCUSSION :: Should we use maven-checkstyle to enforce Java coding style? #3972
wing328
merged commit 4c05d5f into swagger-api:master Nov 23, 2016
|
@nickcmaynard thanks for the PR. I'll run |
wing328
added the
Enhancement: General
label
Nov 23, 2016
wing328
added this to the
v2.2.2
milestone
Nov 23, 2016
|
@wing328 Do you think the codebase is ready for a formatter run yet? |
nickcmaynard
deleted the
nickcmaynard:formatter-maven-plugin branch
Nov 30, 2016
|
@nickcmaynard I'll do it after merging latest enhancements in the master to |
|
Fair - this will cause some conflicts. Just making sure it doesn't get buried under all the other stuff you're doing! |
wing328
referenced
this pull request
Nov 30, 2016
Open
Run mvn formatter:format for better code style/format #4295
|
Yup, I've created #4295 for tracking. |
wing328
added the
Feature: Codegen
label
Feb 22, 2017
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
|
|
nickcmaynard + wing328 |
6d9347b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nickcmaynard commentedNov 18, 2016
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
More work towards our code style standards aim #3972.
Uses Eclipse formatting tools with a configuration matching Google's style guide (plus our customisations).
This brings in an appropriately configured Java formatter maven plugin, but doesn't run it as part of the build. To manually run it:
mvn formatter:formatHaving done this once, we fix ~2200 code style warnings.
I haven't included the results of a run in this PR, as it would generate lots of merge conflicts... I'd suggest whoever merges this PR does a once-off formatter run.