/swagger-codegen

Run all the CLI commands in the Docker environment #5564

Merged
merged 3 commits into from May 8, 2017
+15 −15

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Docker Enhancement: General
Projects
None yet
Milestone
  v2.2.3
2 participants
@ppentchev @wing328
@ppentchev
Contributor

ppentchev commented May 5, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Hi,

Thanks for developing and maintaining Swagger!

Yesterday I found that I could not run "validate" in Docker, so I made a trivial change to allow the "validate" and "version" commands in the docker-environment shell script. Then it occured to me that it would not be so hard to check if the CLI can handle an arbitrary command, and then a couple of unquoted shell variables caught my eye.

Thanks in advance, and keep up the great work!

G'luck,
Peter

ppentchev added some commits May 5, 2017

@ppentchev ppentchev [docker] Allow "validate" and "version" in Docker 2c28fb0
@ppentchev ppentchev [docker] Allow all the available CLI commands c67e624
@ppentchev ppentchev [docker] Quote some more variables

All checks have passed

3 successful checks
Shippable — Run 3362 status is SUCCESS.
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
3720516

@wing328 wing328 added Docker Enhancement: General labels May 8, 2017

wing328 added this to the v2.2.3 milestone May 8, 2017

@wing328
Member

wing328 commented May 8, 2017

@ppentchev thanks for the enhancement to support validate and version in Docker.

wing328 merged commit f5f3dbd into swagger-api:master May 8, 2017
3 checks passed

3 checks passed

Shippable Run 3362 status is SUCCESS.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidgri davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017

@ppentchev @wing328 ppentchev + wing328 Run all the CLI commands in the Docker environment (#5564) 
* [docker] Allow "validate" and "version" in Docker

* [docker] Allow all the available CLI commands

* [docker] Quote some more variables
 dffb69b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment