Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] Add OkHttpClient.Builder to ApiClient. #7907

Merged

Conversation

ejithon
Copy link
Contributor

@ejithon ejithon commented Mar 26, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#7872

Default constructor of OkHttpClient generates a Builder instance implicitly, but I need to customize it. For instance, set some interceptors by calling addInterceptor()

So I add an explicit Builder to ApiClient.

@wing328
Copy link
Contributor

wing328 commented Mar 30, 2018

cc @jimschubert for review.

@wing328 wing328 added this to the v2.4.0 milestone Apr 6, 2018
@wing328 wing328 merged commit a3322fb into swagger-api:master Apr 6, 2018
@jimschubert
Copy link
Contributor

Sorry. a didn't see the cc from a week ago. The change looks good to me, although I didn't run to test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants