From 2506a8135d6afe23357e8cb58159ac696c01c071 Mon Sep 17 00:00:00 2001 From: magbareya Date: Mon, 7 Sep 2015 19:11:07 +0300 Subject: [PATCH] Update ModelImpl.java 1) When we call 'addRequired' we need to add it also to 'required' field. 2) change the order between 'if' and 'for' because if 'properties' is null, then we don't need to execute the for loop at all --- .../src/main/java/io/swagger/models/ModelImpl.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/swagger-models/src/main/java/io/swagger/models/ModelImpl.java b/modules/swagger-models/src/main/java/io/swagger/models/ModelImpl.java index 8e420b57fc..d273e58373 100644 --- a/modules/swagger-models/src/main/java/io/swagger/models/ModelImpl.java +++ b/modules/swagger-models/src/main/java/io/swagger/models/ModelImpl.java @@ -140,6 +140,7 @@ public void setFormat(String format) { } public void addRequired(String name) { + this.required.add(name); Property p = properties.get(name); if (p != null) { p.setRequired(true); @@ -166,8 +167,8 @@ public List getRequired() { public void setRequired(List required) { this.required = required; - for (String s : required) { - if (properties != null) { + if (properties != null){ + for (String s : required) { Property p = properties.get(s); if (p != null) { p.setRequired(true); @@ -370,4 +371,4 @@ public boolean equals(Object obj) { } return true; } -} \ No newline at end of file +}