Send streams directly when using OAS3 #1452
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It basically fixes the problem reported in this comment.
The problem is, that streams are serialized by the swagger client to a string (via JSON.stringify), which should not be done. They should be passed on to the
FormDataas is.How Has This Been Tested?
I tested uploading files via stream. Before it did not work, after it did.
Types of changes
package.json)I'm not sure about the breaking change. I removed the Buffer handling from the code. But it was not working anyway. So I'm not sure if you want to treat this as breaking.
The problem is, that for buffers, a file name has to be set since it cannot be inferred by FormData. (See form-data's alternative submission methods section):
The problem is, that we cannot just set
bufferor some constant. The server can then not infer the file type since there is no mime type and no file extension for the file.Checklist:
I'm not sure about code style. The linter does not compalin, but I don't know if you have any additional code style rules.