Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger v2 converter does not use specialized Schema subclasses #1164

Closed
blast-hardcheese opened this issue Aug 1, 2019 · 2 comments

Comments

@blast-hardcheese
Copy link
Contributor

commented Aug 1, 2019

The swagger converter just does new Schema, then setType and setFormat manually afterwards.

This prevents consumers from being able to isInstanceOf[StringSchema], requiring isInstanceOf[StringSchema] && schema.getType() == "string" everywhere, defeating the purpose of having those specialized schemas in the first place.

@blast-hardcheese

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

I'm going to take a stab at this, just opening an issue to track the work.

@blast-hardcheese

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

This turned out to be much more straightforward than I anticipated that it would be, due to the structure of PrimitiveType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.