Bad indentation of definition breaks Models component

[plavski]

Q&A (please complete the following information)

• OS: macOS
• Browser: chrome
• Version: 67
• Method of installation: npm
• Swagger-UI version: 3.17.4
• Swagger/OpenAPI version: Swagger 2.0

Content & configuration

Example Swagger/OpenAPI definition:

swagger: "2.0"
info:
  description: This is a simple API
  version: 1.0.0
  title: Simple Inventory API

paths:
  /inventory:
    get:
      responses:
        200:
          description: search results matching criteria
        400:
          description: bad input parameter
definitions:
    InventoryItem:
      type: object

Describe the bug you're encountering

A definition with only one model, when incorrectly indented, will crash the Models component.

To reproduce...

Steps to reproduce the behavior:

1. Load above YAML
2. Indent InventoryItem so it is inline with type: object
3. Models component crashes with error

Expected behavior

InventoryItem and type to become individual definitions

Screenshots

Additional context or thoughts

Seems to be an issue the JSON generating invalid Immutable Maps so the Model component crashes when performing a .get("title").

[bestmike007]

Converted to json reveals the answer: https://www.json2yaml.com/

Neither null nor "object" is a valid Schema Object: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#schemaObject

[hkosova]

@bestmike007 did you mean "... is NOT a valid Schema Object"?

[bestmike007]

@hkosova sorry for the typo.

[shockey]

@bestmike007 is right, this is invalid OpenAPI - but we can do better at handling this edge case than blowing up the component 😄