Skip to content

Conversation

@jordangarside
Copy link
Contributor

Adds displayOperationId support to the react package.

Description

Adds the prop validation and uses the prop on initialization of the SwaggerUI.

Motivation and Context

We would like to display the operationId from the react package.

How Has This Been Tested?

Tested this by changing my local node_modules file and setting the prop.

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai self-assigned this Jun 10, 2020
@tim-lai tim-lai merged commit bd1b297 into swagger-api:master Jun 12, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Jun 12, 2020

@jordangarside Merged! Thanks for the contribution!

@frantuma frantuma added this to the M3 milestone Jun 17, 2020
mattyb678 pushed a commit to mattyb678/swagger-ui that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants