Skip to content

Conversation

@tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jun 2, 2020

Description

Per Cypress Docs example for .as, use cy.wait('@routeAlias') instead of cy.get(). Reason: cy.get() will retry until resolved or timeout, while cy.wait() will wait until resolved.

Motivation and Context

3rd effort...
Fixes #6001

How Has This Been Tested?

tests continue to pass locally

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 5bbd3e7 into swagger-api:master Jun 2, 2020
@tim-lai tim-lai deleted the test/6001-flaky-4641-test branch June 5, 2020 22:36
mattyb678 pushed a commit to mattyb678/swagger-ui that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test for bugs/4641

1 participant