Skip to content

Conversation

@geraldglynn
Copy link
Contributor

Description

Added entrySeq() to Request Body properties map to deal with keys being exposed by React

Motivation and Context

Duplicate keys were showing in SwaggerUI under Request Body

How Has This Been Tested?

Ran dev locally to inspect

Screenshots (if appropriate):

Bug
image
Fix
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@geraldglynn geraldglynn reopened this Jul 28, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Jul 28, 2020

@geraldglynn We should handle case if .entrySeq is not available or not a function. Then have a Cypress test that confirms screenshot 2 (fix), and that error in screenshot 1 does not exist.

@tim-lai tim-lai self-assigned this Jul 28, 2020
@tim-lai tim-lai merged commit 0199b47 into swagger-api:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants