servers environment select style fix #6367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi!
There is subtle styling problem with environment select which causes the select input to overlap the
environmentlabel text. The amount of overlapping also depends on width of the select text.Motivation and Context
Q: Why is this change required?
A: Because beautiful is better than ugly. :)
How Has This Been Tested?
I did not have enough time to investigate markup codes to check whether the changed css rules used in any other places, but as a fast check, I used Firefox's
Highlight all elements matching this selectortool, as shown in the screenshot/screencast, to toggle all elements affected by these rules. Although these rules are applied to more than one element in through document, but changes do not corrupt anything.Screenshots (if appropriate):
For sure!
Here is the link to it: https://sendvid.com/9czmuzx1
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests
It may require other contributors review...