Skip to content

Conversation

@xeptore
Copy link
Contributor

@xeptore xeptore commented Sep 9, 2020

Description

Hi!
There is subtle styling problem with environment select which causes the select input to overlap the environment label text. The amount of overlapping also depends on width of the select text.

Motivation and Context

Q: Why is this change required?
A: Because beautiful is better than ugly. :)

How Has This Been Tested?

I did not have enough time to investigate markup codes to check whether the changed css rules used in any other places, but as a fast check, I used Firefox's Highlight all elements matching this selector tool, as shown in the screenshot/screencast, to toggle all elements affected by these rules. Although these rules are applied to more than one element in through document, but changes do not corrupt anything.

Screenshots (if appropriate):

For sure!
Here is the link to it: https://sendvid.com/9czmuzx1

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.
    It may require other contributors review...

@tim-lai tim-lai merged commit 7a63ba3 into swagger-api:master Sep 10, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Sep 10, 2020

@xeptore Merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants