Skip to content

Conversation

@lsarni
Copy link
Contributor

@lsarni lsarni commented Oct 8, 2020

Description

Hide readOnly properties on PUT and POST actions, both on the overview and when trying the action out.

It would be possible to hide it only on the "Try out" step or also to keep the property label but not show the input field, I wasn't sure of what was the ideal fix. Do let me know if you would prefer a different fix.

Motivation and Context

Fixes #6158

How Has This Been Tested?

Tested locally using the definition given at #6158 with an added put action.

Screenshots (if appropriate):

image (3)
image (4)
image (5)
image (6)

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@lsarni lsarni force-pushed the fix/hide-read-only-properties branch 3 times, most recently from 74d5499 to 7953fb7 Compare October 9, 2020 11:17
@lsarni lsarni force-pushed the fix/hide-read-only-properties branch from 7953fb7 to 310e55b Compare October 14, 2020 08:30
@tim-lai tim-lai merged commit 5065613 into swagger-api:master Oct 15, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 15, 2020

@lsarni Merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.x] read-only property is not hidden in POST/PUT

2 participants