Add support for showExtensions on Response objects #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelbys
changed the title
Contributor
|
@shelbys Thanks for the PR! Functionally looks good. However, it should come with new tests 1) where using |
tim-lai
suggested changes
Oct 20, 2020
* upstream/master: housekeeping(dev-deps): nightwatch@1.5.0 fix(auth): Allow PKCE for legacy AccessCode OAuth2 Grant Type (swagger-api#6011) housekeeping(dev-deps): mini-css-extract-plugin@1.1.1 chore(deps): bump ua-parser-js to v0.7.22 (swagger-api#6539) housekeeping(dev-deps): eslint-plugin-react@7.21.5
Contributor
Author
|
@tim-lai - Renamed to ResponseExtension, and tests added |
tim-lai
approved these changes
Oct 22, 2020
Contributor
|
@shelbys Merged! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you appreciate this contribution, please add a
hacktoberfest-acceptedLabel to the PR, so it'll be trackedDescription
Add same ability to show
x-extensions for Response objects, just like already supported for Operations, Parameters, and SchemasMotivation and Context
We actively use
x-extensions on Response objects to better detail individual cases, but they're currently not shown in `swagger-uiHow Has This Been Tested?
I manually verified locally with changes to PetStore, but didn't find any automated tests to extend. Let me know if I missed anything
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests