Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for content-types which contain a quote symbol. #1801

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

spadger
Copy link

@spadger spadger commented Dec 7, 2015

We are using a content-type which contains a URL, that needs to be quoted. This causes some sad HTML rendering since the urls aren't endocded when being rendered.

Our content-type is application/hal+json; charset=utf-8; version=1.0; profile="http://donate-api.justgiving.com/profiles"

fehguy added a commit that referenced this pull request Dec 7, 2015
Add support for content-types which contain a quote symbol.
@fehguy fehguy merged commit 0476b4c into swagger-api:master Dec 7, 2015
@fehguy fehguy modified the milestone: v2.1.4 Jan 6, 2016
@joevennix
Copy link
Contributor

This commit introduced the XSS vulnerability I fixed in PR #1867. The content-type should render correctly now; I don't understand what was wrong here, and there aren't repro steps. Did it send up the wrong value when you sent the request?

vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this pull request Aug 19, 2016
Add support for content-types which contain a quote symbol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants