New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checking that the response has a content-length for download links #3895

Merged
merged 7 commits into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@conorlennon
Contributor

conorlennon commented Nov 12, 2017

download link available.

Description

Dynamic content often results in the HTTP response header not having a content-length field.
If a download link is to be displayed, a HTTP response without a content-length field should be supported.
Removing the check does not appear to break the download link functionality.

Motivation and Context

Fixes #3149

How Has This Been Tested?

Tested with HTTP response with no content-length.
Download link is displayed and the download contents is correct

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@webron webron requested a review from shockey Nov 13, 2017

conorlennon added some commits Nov 17, 2017

@shockey shockey merged commit 5269325 into swagger-api:master Nov 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shockey

This comment has been minimized.

Show comment
Hide comment
@shockey

shockey Nov 28, 2017

Member

Thanks @conorlennon! 😄

Member

shockey commented Nov 28, 2017

Thanks @conorlennon! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment