From ae75dc66d33efefb082e2e6b3ceb358ac958aba3 Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sat, 10 Mar 2018 20:58:18 -0500 Subject: [PATCH 1/7] Add "copy-button": "2.0.0", --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 7bb25b61443..13dae493b62 100644 --- a/package.json +++ b/package.json @@ -45,6 +45,7 @@ "brace": "0.7.0", "classnames": "^2.2.5", "commonmark": "^0.28.1", + "copy-button": "2.0.0", "core-js": "^2.5.1", "css.escape": "1.5.1", "deep-extend": "0.4.1", From ace8936784d36421cba4897e0e0ac64714cd781d Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sat, 10 Mar 2018 23:11:58 -0500 Subject: [PATCH 2/7] Replace copy-button w/ react-copy-to-clipboard --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 13dae493b62..67c13d776ff 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,6 @@ "brace": "0.7.0", "classnames": "^2.2.5", "commonmark": "^0.28.1", - "copy-button": "2.0.0", "core-js": "^2.5.1", "css.escape": "1.5.1", "deep-extend": "0.4.1", @@ -64,6 +63,7 @@ "react-addons-shallow-compare": "0.14.8", "react-addons-test-utils": "^15.6.2", "react-collapse": "^4.0.3", + "react-copy-to-clipboard": "5.0.1", "react-debounce-input": "^3.2.0", "react-dom": "^15.6.2", "react-height": "^2.0.0", From 49e7982e3e614367fde9ad9ce0b8f66cd7f5a223 Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sat, 10 Mar 2018 23:12:18 -0500 Subject: [PATCH 3/7] Inital test of CopyToClipboard --- src/core/components/response-body.jsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/components/response-body.jsx b/src/core/components/response-body.jsx index 640e00075c5..2dc3f0e73cc 100644 --- a/src/core/components/response-body.jsx +++ b/src/core/components/response-body.jsx @@ -2,6 +2,7 @@ import React from "react" import PropTypes from "prop-types" import formatXml from "xml-but-prettier" import lowerCase from "lodash/lowerCase" +import { CopyToClipboard } from 'react-copy-to-clipboard'; import { extractFileNameFromContentDispositionHeader } from "core/utils" import win from "core/window" @@ -103,6 +104,7 @@ export default class ResponseBody extends React.Component { return ( !bodyEl ? null :
Response body
+ { bodyEl }
) From cc89135036c8b966528dd084535c2b1150d11ad8 Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sun, 11 Mar 2018 12:22:53 -0400 Subject: [PATCH 4/7] Align CopyToClip w/ Response body H5 --- src/core/components/response-body.jsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/components/response-body.jsx b/src/core/components/response-body.jsx index 2dc3f0e73cc..c7036401bd7 100644 --- a/src/core/components/response-body.jsx +++ b/src/core/components/response-body.jsx @@ -103,8 +103,7 @@ export default class ResponseBody extends React.Component { } return ( !bodyEl ? null :
-
Response body
- +
Response body
{ bodyEl }
) From 2e2a84d6029bc2f0f746ca37db88de763da13eed Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sun, 11 Mar 2018 12:23:17 -0400 Subject: [PATCH 5/7] Style button.copy-to-clipboard --- src/style/_layout.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/style/_layout.scss b/src/style/_layout.scss index 4a117e5a99a..7ecd497950f 100644 --- a/src/style/_layout.scss +++ b/src/style/_layout.scss @@ -769,3 +769,10 @@ a.nostyle { cursor: pointer; } } + +button.copy-to-clipboard { + float: right; + width: 10px; + height: 20px; + background: url("data:image/svg+xml;utf8,") center center no-repeat; +} From 1722715f97b4ca8750c72a171a12b15ec82fccf3 Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Sun, 11 Mar 2018 12:56:02 -0400 Subject: [PATCH 6/7] Strings must use doublequote --- src/core/components/response-body.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/components/response-body.jsx b/src/core/components/response-body.jsx index c7036401bd7..2c978422454 100644 --- a/src/core/components/response-body.jsx +++ b/src/core/components/response-body.jsx @@ -2,7 +2,7 @@ import React from "react" import PropTypes from "prop-types" import formatXml from "xml-but-prettier" import lowerCase from "lodash/lowerCase" -import { CopyToClipboard } from 'react-copy-to-clipboard'; +import { CopyToClipboard } from "react-copy-to-clipboard" import { extractFileNameFromContentDispositionHeader } from "core/utils" import win from "core/window" From f58554cc933f9d7af50e181ddc4331c5dea64311 Mon Sep 17 00:00:00 2001 From: Helder Sepulveda Date: Tue, 13 Mar 2018 15:57:18 -0400 Subject: [PATCH 7/7] Use the GitHub copy icon --- src/style/_layout.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/style/_layout.scss b/src/style/_layout.scss index 7ecd497950f..2f36fec9477 100644 --- a/src/style/_layout.scss +++ b/src/style/_layout.scss @@ -772,7 +772,8 @@ a.nostyle { button.copy-to-clipboard { float: right; - width: 10px; + border: none; + width: 16x; height: 20px; - background: url("data:image/svg+xml;utf8,") center center no-repeat; + background: url("data:image/svg+xml;utf8,") center center no-repeat; }