Skip to content

Conversation

@maryscar
Copy link
Contributor

Description

Fixes 1 common accessibility issue with font color contrast in the Models property section that effect visual accessibility.

Motivation and Context

Fixes 2 common accessibility issues with font color contrast in the Models property section. Suggested updates to styling.
#4539

How Has This Been Tested?

Ran npm tests.
Accessibility testing was completed using internal tools as well as Google Accessibility Extension (https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb) and aXe Accessibility Engine (https://www.deque.com/products/axe/).

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

maryscar and others added 7 commits January 17, 2018 12:37
Merge from swagger-api/swagger-ui Master
Merge swagger-api/swagger-ui into maryscar/swagger-ui
…ccessibility color contrast threshold.
…on_Model_properties_#4539

Update inline style from swagger-api#999 to swagger-api#666 to meet accessibility color con…
@shockey shockey merged commit 66e9bd7 into swagger-api:master May 10, 2018
@shockey
Copy link
Contributor

shockey commented May 10, 2018

thanks @maryscar! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants