fix: consistent behavior with multiple invocations of SwaggerUI #4923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in which Swagger UI's system constructor will, with certain plugin structures, mangle the original plugin that was passed into Swagger UI.
This leads to inconsistent behavior when the same object is passed into Swagger UI again, which is part of some users' workflows.
Motivation and Context
Fixes #4865.
How Has This Been Tested?
I added Cypress tests for the top-level behavior mentioned in the ticket, and unit tests for the underlying system mechanism.
Per TDD, both sets of tests fail without this change.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests