-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Display nullable for object model itself (#5660)
#5868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display nullable for object model itself (#5660)
#5868
Conversation
|
Are cypress tests required for such changes? |
tim-lai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vovan-VE Please add Cypress or Mocha tests to this PR. Otherwise, this change looks good. Thanks!
|
Should it render |
Yes. Ok to display whatever the actual boolean value is. Thanks. |
|
@Vovan-VE Merged! Thanks for the contribution1 |
Description
Display
nullablemarker for object model itself.To display a
nullablemarker I used the same semantic as already used for primitive types, t.i. I displaynullable: <boolean>when it is provided in schema independent of its valuetrue/false.Motivation and Context
Fixes #5660. When a property is nullable object, the model view did not show
nullablestatus. This is a lack of information provided by an underlying schema.As an example, a property may be required (that is always presented in a response or must be explicitly passed in a request), but can also be
nulland not required always to be an object.How Has This Been Tested?
dev-helpers/test.yml:npm run devand loaded/test.ymlnullable: trueboth formetaproperty definition and wholeSomeObjectmodel itself. I played with thisnullables by commenting them out and reloading/test.ymlon page.Also I did check and confirm than I did not see
nullablemarkers in step 3 before my changes.Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests