Skip to content

Conversation

@Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Oct 7, 2020

Description

Add autofocus auth fields

Motivation and Context

Fixes #6395

How Has This Been Tested?

Not tested

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@Saibamen Saibamen marked this pull request as ready for review October 7, 2020 15:08
@tim-lai
Copy link
Contributor

tim-lai commented Oct 8, 2020

@Saibamen Thanks for the PR! Please add a Cypress test(s) to validate this change. You will probably want to use cy.focused()

@tim-lai
Copy link
Contributor

tim-lai commented Oct 8, 2020

fails CI with features/oauth2-flows/application.js

@Saibamen
Copy link
Contributor Author

Saibamen commented Oct 8, 2020

Fixed

@tim-lai tim-lai merged commit 65ea764 into swagger-api:master Oct 15, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 15, 2020

@Saibamen Merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add autofocus for input field generated by OpenApiSecurityScheme

2 participants