Change new Buffer to Buffer.from after deprecation #6489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using
new Bufferwe should useBuffer.fromfrom hereThis code was introduced to fix #6366 so I tested the given user and password after the changes with a
swagger: 2.0file that uses basic auth as explained here:In this case it works as expected, preserving the original bug fix.
While testing I noted that this no longer works for swagger 3.0 where the basic auth is declared as explained here:
In that case it ends up going into this branch so it doesn't use the custom
btoafunction.Motivation and Context
Fixes #6366
How Has This Been Tested?
Tested locally with
swagger: "2.0"file that uses basic authentication.Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests