Skip to content

fix: Fixed keys rendering in React 16 using .entrySeq() #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2020
Merged

fix: Fixed keys rendering in React 16 using .entrySeq() #6685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca9c4c7
fix: Fixed keys rendering in React 16 using .entrySeq()
geraldglynn Dec 9, 2020
dba5c95
Merge branch 'master' into fix/duplicate-labels-in-parameter-and-resp…
char0n Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/components/parameter-row.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ export default class ParameterRow extends Component {
</div>
<div className="parameter__in">({ param.get("in") })</div>
{ !showCommonExtensions || !commonExt.size ? null : commonExt.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
{ !showExtensions || !extensions.size ? null : extensions.map((v, key) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
{ !showExtensions || !extensions.size ? null : extensions.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
</td>

<td className="parameters-col_description">
Expand Down
4 changes: 2 additions & 2 deletions src/core/components/response.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export default class Response extends React.Component {
<Markdown source={ response.get( "description" ) } />
</div>

{ !showExtensions || !extensions.size ? null : extensions.map((v, key) => <ResponseExtension key={`${key}-${v}`} xKey={key} xVal={v} /> )}
{ !showExtensions || !extensions.size ? null : extensions.entrySeq().map(([key, v]) => <ResponseExtension key={`${key}-${v}`} xKey={key} xVal={v} /> )}

{isOAS3 && response.get("content") ? (
<section className="response-controls">
Expand Down Expand Up @@ -255,7 +255,7 @@ export default class Response extends React.Component {
</td>
{isOAS3 ? <td className="response-col_links">
{ links ?
links.toSeq().map((link, key) => {
links.toSeq().entrySeq().map(([key, link]) => {
return <OperationLink key={key} name={key} link={ link } getComponent={getComponent}/>
})
: <i>No links</i>}
Expand Down