Skip to content

Include description of oauth endpoints when parsing openapi #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Include description of oauth endpoints when parsing openapi #7195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d3111
Include description of oauth endpoints when parsing openapi
michaelzangl Apr 19, 2021
19c1e20
Merge branch 'master' into bug/5230-fix-openapi3-auth-missing-descrip…
michaelzangl Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/plugins/oas3/auth-extensions/wrap-selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ export const definitionsToAuthorize = onlyOAS3(createSelector(
authorizationUrl: flowVal.get("authorizationUrl"),
tokenUrl: flowVal.get("tokenUrl"),
scopes: flowVal.get("scopes"),
type: definition.get("type")
type: definition.get("type"),
description: definition.get("description")
})

list = list.push(new Map({
Expand Down
6 changes: 4 additions & 2 deletions test/unit/core/plugins/oas3/wrap-auth-selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe("oas3 plugin - auth extensions - wrapSelectors", function(){
return fromJS({
"oauth2AuthorizationCode": {
"type": "oauth2",
"description": "Some Oauth2 endpoint",
"flows": {
"authorizationCode": {
"authorizationUrl": "http://google.com/",
Expand Down Expand Up @@ -105,7 +106,8 @@ describe("oas3 plugin - auth extensions - wrapSelectors", function(){
scopes: {
"myScope": "our only scope"
},
type: "oauth2"
type: "oauth2",
description: "Some Oauth2 endpoint"
}
},
{
Expand Down Expand Up @@ -201,7 +203,7 @@ describe("oas3 plugin - auth extensions - wrapSelectors", function(){
// OPTIONAL. JSON array containing a list of the OAuth 2.0 Grant Type values that
// this OP supports. Dynamic OpenID Providers MUST support the authorization_code
// and implicit Grant Type values and MAY support other Grant Types. If omitted,
// the default value is ["authorization_code", "implicit"].
// the default value is ["authorization_code", "implicit"].
oidcNoGrant: {
flow: "authorization_code",
authorizationUrl: "https://accounts.google.com/o/oauth2/v2/auth",
Expand Down