Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gin-contrib/gzip to latest version #220

Merged
merged 1 commit into from Jul 6, 2022

Conversation

venu-prasanna-tw
Copy link
Contributor

We are using the latest version of [github.com/swaggo/gin-swagger@v1.5.0] which internally uses the gin-contrib/gzip library and the version is [github.com/gin-contrib/gzip@v0.0.5] in go.mod

This has introduced snyk vulnerability HTTP Response Splitting with the following path:
github.com/swaggo/gin-swagger@v1.5.0 › github.com/gin-contrib/gzip@v0.0.5 › github.com/gin-gonic/gin@v1.7.4

Snyk issue link: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMGINGONICGIN-1041736

In order to solve this issue I have upgraded gin-contrib/gzip to latest version.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #220 (8ba2eb4) into master (0806351) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           98        98           
=========================================
  Hits            98        98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0806351...8ba2eb4. Read the comment docs.

ubogdan
ubogdan approved these changes Jul 6, 2022
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit b9e926c into swaggo:master Jul 6, 2022
8 checks passed
@ubogdan
Copy link
Contributor

ubogdan commented Jul 6, 2022

@venu-prasanna-tw Thanks for your contribution.

@ruchi-dhore-tw
Copy link

@ubogdan any idea when this change would be released?

@ubogdan
Copy link
Contributor

ubogdan commented Jul 7, 2022

released.

@ruchi-dhore-tw
Copy link

Thank you @ubogdan !

@ubogdan
Copy link
Contributor

ubogdan commented Jul 7, 2022

You're welcome. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants