Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't skip ".." directory #1238

merged 1 commit into from Jun 27, 2022

fix: don't skip ".." directory #1238

merged 1 commit into from Jun 27, 2022


Copy link

@haoqixu haoqixu commented Jun 20, 2022

Parser.Skip() treats .. directory as hidden folder and return a filepath.SkipDir. If .. is provided via --dir option, swag will miss some files.

Copy link

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1238 (58a9569) into master (0e2ec6c) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1238      +/-   ##
+ Coverage   94.83%   94.91%   +0.07%     
  Files          14       14              
  Lines        2614     2614              
+ Hits         2479     2481       +2     
+ Misses         74       73       -1     
+ Partials       61       60       -1     
Impacted Files Coverage Δ
parser.go 93.59% <100.00%> (ø)
packages.go 88.35% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2ec6c...58a9569. Read the comment docs.

@ubogdan ubogdan merged commit 1cd0b53 into swaggo:master Jun 27, 2022
12 checks passed
Copy link

ubogdan commented Jun 27, 2022

@haoqixu Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants